Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395764
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface |
| Date | 2016-05-06 12:50 +0200 |
| Message-ID | <rvLuy-3mA-13@gated-at.bofh.it> (permalink) |
| References | <rsy0O-22y-3@gated-at.bofh.it> <rsy0P-22y-23@gated-at.bofh.it> <rvvJ9-4je-19@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote: > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > > > > + bool polarity; > So this variable is not very intuitively named. There is a help above. This is a property of the Synopsys DesignWare DMA engine. Anyone familiar with datasheet easily understands this. > > You end up setting somepointer->polarity = true; in a later patch. > > Since you're respining a V4 I'd suggest a name that describes a little > bit better than polarity. Setting polarity = true is a little bit > liked > being asked "you you like ice-cream or apple pie" and then saying "yes > please". It's about handshake interface polarity, so, what about hs_polarity? -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-05 20:00 +0200
Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-06 12:50 +0200
Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-06 13:20 +0200
csiph-web