Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395259 > unrolled thread

Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-05 20:00 +0200
    Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-06 12:50 +0200
      Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-06 13:20 +0200

#1395259 — Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> +       bool                    polarity;

So this variable is not very intuitively named.

You end up setting somepointer->polarity = true; in a later patch. 

Since you're respining a V4 I'd suggest a name that describes a little
bit better than polarity. Setting polarity = true is a little bit liked
being asked "you you like ice-cream or apple pie" and then saying "yes
please".

---
bod

[toc] | [next] | [standalone]

#1395764

On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote:
> On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> > 
> > +       bool                    polarity;
> So this variable is not very intuitively named.

There is a help above. This is a property of the Synopsys DesignWare DMA
engine. Anyone familiar with datasheet easily understands this.

> 
> You end up setting somepointer->polarity = true; in a later patch. 
> 
> Since you're respining a V4 I'd suggest a name that describes a little
> bit better than polarity. Setting polarity = true is a little bit
> liked
> being asked "you you like ice-cream or apple pie" and then saying "yes
> please".

It's about handshake interface polarity, so, what about hs_polarity?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1395778

On Fri, 2016-05-06 at 13:42 +0300, Andy Shevchenko wrote:

> It's about handshake interface polarity, so, what about hs_polarity?

Works for me.

---
bod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web