Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

From	Bryan O'Donoghue <pure.logic@nexus-software.ie>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
Date	2016-05-05 20:00 +0200
Message-ID	<rvvJ9-4je-19@gated-at.bofh.it> (permalink)
References	<rsy0O-22y-3@gated-at.bofh.it> <rsy0P-22y-23@gated-at.bofh.it>
Organization	Nexus Software

Show all headers | View raw

On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> +       bool                    polarity;

So this variable is not very intuitively named.

You end up setting somepointer->polarity = true; in a later patch. 

Since you're respining a V4 I'd suggest a name that describes a little
bit better than polarity. Setting polarity = true is a little bit liked
being asked "you you like ice-cream or apple pie" and then saying "yes
please".

---
bod

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-05 20:00 +0200
  Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-06 12:50 +0200
    Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-05-06 13:20 +0200

csiph-web