Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390551

Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc

Show all headers | View raw

Hi,

On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> +       I2C_FS_SPD,
> +       I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition?  Seems like it's not
> necessary.  Remove?
>
>
> I think we need a Master_Code state to seperate from other state.

I meant remove the line above the contains just:

  struct rk3x_i2c;

...I don't believe it's needed.  You only need a forward declaration
like that if you refer to the structure before it's defined.


-Doug

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc Doug Anderson <dianders@chromium.org> - 2016-04-28 23:30 +0200

csiph-web