Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1390551 > unrolled thread
| Started by | Doug Anderson <dianders@chromium.org> |
|---|---|
| First post | 2016-04-28 23:30 +0200 |
| Last post | 2016-04-28 23:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc Doug Anderson <dianders@chromium.org> - 2016-04-28 23:30 +0200
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2016-04-28 23:30 +0200 |
| Subject | Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc |
| Message-ID | <rt1Fw-2Aw-11@gated-at.bofh.it> |
Hi,
On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> + I2C_FS_SPD,
> + I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition? Seems like it's not
> necessary. Remove?
>
>
> I think we need a Master_Code state to seperate from other state.
I meant remove the line above the contains just:
struct rk3x_i2c;
...I don't believe it's needed. You only need a forward declaration
like that if you refer to the structure before it's defined.
-Doug
Back to top | Article view | linux.kernel
csiph-web