Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc
Date	Thu, 28 Apr 2016 23:30:02 +0200
Message-ID	<rt1Fw-2Aw-11@gated-at.bofh.it> (permalink)
References	<rdBWH-50M-19@gated-at.bofh.it> <rpEm6-7KL-11@gated-at.bofh.it> <rsEIW-7JR-5@gated-at.bofh.it> <rt1Fw-2Aw-13@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=aBcY4XhCyqHH+FkLljuLhMaWMXB9DUf21OsEvDHIkdI=; b=BnMLW2qcVWm+WGejaJsl1o0Gd8CmgOCMusXRTeGRlPLDYWFfGv04/rtiIqGaNY8kJ9 5GxOjy8620vxtRyzqBMgl7UD40tkzZX94X5gYFA99MZTCVmjt1O2i8CrqBgt9kqAUHbn ogIpqRY7GTbWW9DMJnXJoYKnIiGXH7bbaWUL20vujl4WJCIpSJzAAWHUgnEli1mLIkky ajV5vbhIdE7D0e0lLHgKU4CJLyXECNx1V9uUo/UCWkgYjuE6wloI4MD4IBxNzd/W9o1T CDiTnNgWW7Ka0lfhVKKHGZbXuB4W2p2qCHu8sgjo+K2jmnDyO7AZUJdampKu0fn/gsNS vM4Q==
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=aBcY4XhCyqHH+FkLljuLhMaWMXB9DUf21OsEvDHIkdI=; b=JCd8mahvGZEjTfjCY5h65r72Y+YbPRbiKfmZ5DskNit6b20AxrScrANj6MUHFBXSUq swX3RgFep4U23cJDOSiT4PhykZs8o/3dsRde02HQW/BAemU7w4w6k/Ob2Dve5ilWDA5e WGWMvnb9Fz8qsXrDLzT46CAFdKVF7NoWKQ9d8=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=aBcY4XhCyqHH+FkLljuLhMaWMXB9DUf21OsEvDHIkdI=; b=BGx/1fT1hbxNWR8W29xqExVlrMZFOImjoS8dgbR1BdsGGEcYWDNPBJG3pXEI9LEhVH mkxVdLPpkLjfEqalcCvpPUXq/MELZufGwpdVMn1bEouwY/1VzTRX6U/W99/DWSCAritM uD1HH+39vnjwkrz+k0bvadQi028iRnThs6y7z7TxKGzUFLA/2oXtYMUhwqNO9upTF5nW kHqd0Xk2/IpYE0hwETyFm3oyXzDppnsNs5a33KAA+/CxKR+Z+5pREC2ndkHqB3jxnwpS drZemO2kF4YsXPN++ASv9YNuJMBmn4XCIrEKinFBS+vJcaqu673bK3NFsp6roitjbYof ZReA==
X-Gm-Message-State	AOPr4FXHv/DF5cTQw7rl+HJTvy3XSTp25mx8+XSaKIa3ymb0ORmqTmcYtdeaiyHji7omhdu19SraaG51MpGUwksU
MIME-Version	1.0
X-Received	by 10.176.2.75 with SMTP id 69mr9613197uas.104.1461878914141; Thu, 28 Apr 2016 14:28:34 -0700 (PDT)
X-Google-Sender-Auth	mL8ZEzhnkU3b0OOFbYdBalD904Q
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Heiko Stübner <heiko@sntech.de>, Wolfram Sang <wsa@the-dreams.de>, Andy Shevchenko <andy.shevchenko@gmail.com>, Tao Huang <huangtao@rock-chips.com>, Lin Huang <hl@rock-chips.com>, Jianqun Xu <xjq@rock-chips.com>, Chris <zyw@rock-chips.com>, Eddie Cai <cf@rock-chips.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, David Wu <wdc@rock-chips.com>, Brian Norris <briannorris@google.com>, David Riley <davidriley@google.com>
X-Original-Date	Thu, 28 Apr 2016 14:28:34 -0700
X-Original-Message-ID	<CAD=FV=WxoZArMyhAPEmhG4FVHqhd-snMt59_Hk=BVsP2hZBxpw@mail.gmail.com>
X-Original-References	<1458147438-62387-3-git-send-email-david.wu@rock-chips.com> <1461074137-23899-1-git-send-email-david.wu@rock-chips.com> <CAD=FV=U7Vsnh8RZjZ=an0Sfb+soS=+v1icoH=kL1huCR_9TTgA@mail.gmail.com> <572212AE.5060904@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1390551

Show key headers only | View raw

Hi,

On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> +       I2C_FS_SPD,
> +       I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition?  Seems like it's not
> necessary.  Remove?
>
>
> I think we need a Master_Code state to seperate from other state.

I meant remove the line above the contains just:

  struct rk3x_i2c;

...I don't believe it's needed.  You only need a forward declaration
like that if you refer to the structure before it's defined.

-Doug

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc Doug Anderson <dianders@chromium.org> - 2016-04-28 23:30 +0200

csiph-web