Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362767

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

Show all headers | View raw

On Tue, 22 Mar 2016, Oliver Neukum wrote:

> On Mon, 2016-03-21 at 15:30 -0400, Alan Stern wrote:
> > On Mon, 21 Mar 2016, Oliver Neukum wrote:
> > 
> 
> > > We have an autosuspend timeout because we think that IO, if it will
> > > come at all, is likeliest to come soon. If, however, the IO is
> > > periodic that heuristics is false.
> > > To save most power the driver must either decide that the interval
> > > is too short or suspend immediately. So if we are lucky enough
> > > to have the frequency in the kernel, we should use that information.
> > 
> > The autosuspend timeout is set by userspace.  The kernel may assign a
> 
> Thus it should apply to all IO originating in user space.
> But only to that IO.

Fair enough.

> > default value, but the user can always override it.  Given this, I 
> > don't see how the kernel can use frequency information (and I'm not 
> > sure where that information would come from in the first place).
> 
> It can ignore internal IO for the purpose of the timeout.
> If such IO is performed while the device is active, don't
> alter the timer.

Come to think of it, we don't.  If pm_runtime_get_sync() and then
pm_runtime_put() are called while the device is already at full power, 
the PM core doesn't update the last_busy time.  So if the driver 
doesn't update it either, the statistics collection won't interfere 
with autosuspend (except when it races with the autosuspend timer 
expiration).

> Otherwise resume the device and look at
> the provided hint and suspend again immediately if the period is long
> enough.

I don't see any point in resuming the device just in order to collect 
operating statistics.  If it was already suspended then it wasn't 
operating, so there will be no statistics to collect.

> If IO is generated periodically in the kernel, the kernel must know that
> period.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-20 11:50 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-20 17:40 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM David Miller <davem@davemloft.net> - 2016-03-20 22:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Guenter Roeck <linux@roeck-us.net> - 2016-03-21 00:00 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 16:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 09:40 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 15:50 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 16:00 +0100
      Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 18:40 +0100
        Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 19:30 +0100
          RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 20:20 +0100
            RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:30 +0100
              RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 21:10 +0100
                RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 22:10 +0100
          Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 20:30 +0100
            Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:40 +0100
              Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 11:00 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 15:30 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 15:40 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 16:20 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 16:40 +0100

csiph-web