Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362150

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

From Alan Stern <stern@rowland.harvard.edu>
Newsgroups linux.kernel
Subject RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
Date 2016-03-21 22:10 +0100
Message-ID <rfffk-2ON-15@gated-at.bofh.it> (permalink)
References <rfejg-2aH-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 21 Mar 2016 Woojung.Huh@microchip.com wrote:

> > > > But this leaves open the issue that querying the device too often will
> > > > prevent it from going into autosuspend.  It seems to me that the best
> > > > way to deal with this is to make sure that the autosuspend timeout is
> > > > shorter than the interal between queries, not to make the querying
> > > > conditional on !runtime_auto.
> > >
> > > Short autosuspend timeout can affect performance. For instance our
> > experiments showed that
> > > shorter than 10sec timeout made Ethernet performance degrade because
> > of wakeup delays.
> > > So, just putting shorter timeout may have some side effects.
> > 
> > Sure.  This just means that you need a long statistics interval --
> > longer than the autosuspend timeout.  That's why I suggested making the
> > interval adjustable.
> 
> What do you mean statistics interval?
> Interval calling ndo_get_stats64 or another thread/timer or else getting statistics?

The time between calls to ndo_get_stats64, since that's the routine 
which queries the device.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-20 11:50 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-20 17:40 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM David Miller <davem@davemloft.net> - 2016-03-20 22:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Guenter Roeck <linux@roeck-us.net> - 2016-03-21 00:00 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 16:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 09:40 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 15:50 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 16:00 +0100
      Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 18:40 +0100
        Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 19:30 +0100
          RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 20:20 +0100
            RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:30 +0100
              RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 21:10 +0100
                RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 22:10 +0100
          Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 20:30 +0100
            Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:40 +0100
              Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 11:00 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 15:30 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 15:40 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 16:20 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 16:40 +0100

csiph-web