Groups > linux.kernel > #1361909

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

From	<Woojung.Huh@microchip.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
Date	2016-03-21 16:00 +0100
Message-ID	<rf9tf-7al-7@gated-at.bofh.it> (permalink)
References	<reJ5L-5DH-9@gated-at.bofh.it> <reUue-51H-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Guenter Roeck [mailto:linux@roeck-us.net]
> Sent: Sunday, March 20, 2016 6:59 PM
> To: Geert Uytterhoeven; Woojung Huh - C21699; UNGLinuxDriver; David S.
> Miller
> Cc: Rafael J. Wysocki; netdev@vger.kernel.org; linux-usb@vger.kernel.org;
> linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef
> CONFIG_PM
>  
> Not that it matters anymore since David reverted the original patch,
> but my reason for not sending a similar patch was that I wasn't sure
> if .runtime_auto should be accessed from drivers in the first place,
> or if there is some logical problem with the code.
> 

Because driver can enable/disable autosuspend by usb_enable_autosuspend() and
usb_disable_autosuspend(), it would be nice to have helper to find out autosuspend status.

The code path was to utilize autosuspend power saving, when it is enabled.

Woojung

Thread

[PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-20 11:50 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-20 17:40 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM David Miller <davem@davemloft.net> - 2016-03-20 22:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Guenter Roeck <linux@roeck-us.net> - 2016-03-21 00:00 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 16:00 +0100
  Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 09:40 +0100
    RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 15:50 +0100
    Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 16:00 +0100
      Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 18:40 +0100
        Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 19:30 +0100
          RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 20:20 +0100
            RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:30 +0100
              RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM <Woojung.Huh@microchip.com> - 2016-03-21 21:10 +0100
                RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 22:10 +0100
          Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-21 20:30 +0100
            Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-21 20:40 +0100
              Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 11:00 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 15:30 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 15:40 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Alan Stern <stern@rowland.harvard.edu> - 2016-03-22 16:20 +0100
                Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Oliver Neukum <oneukum@suse.com> - 2016-03-22 16:40 +0100

csiph-web