Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357618
| From | Michal Simek <michal.simek@xilinx.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/5] net: macb: Fix coding style error message |
| Date | 2016-03-14 21:50 +0100 |
| Message-ID | <rcHB8-pu-23@gated-at.bofh.it> (permalink) |
| References | <rcjIt-1tp-1@gated-at.bofh.it> <rcjIu-1tp-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 13.3.2016 20:10, Moritz Fischer wrote:
> checkpatch.pl gave the following error:
>
> ERROR: space required before the open parenthesis '('
> + for(; p < end; p++, offset += 4)
>
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 50c9410..4370f37 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp)
>
> WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4);
>
> - for(; p < end; p++, offset += 4)
> + for (; p < end; p++, offset += 4)
> *p += bp->macb_reg_readl(bp, offset);
> }
>
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
[PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
[PATCH 5/5] net: macb: Fix simple typo. Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 5/5] net: macb: Fix simple typo. Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 5/5] net: macb: Fix simple typo. Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 15:00 +0100
[PATCH 1/5] net: macb: Fix coding style error message Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 1/5] net: macb: Fix coding style error message Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 1/5] net: macb: Fix coding style error message Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:40 +0100
[PATCH 2/5] net: macb: Fix coding style warnings Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 2/5] net: macb: Fix coding style warnings Michal Simek <michal.simek@xilinx.com> - 2016-03-14 22:00 +0100
Re: [PATCH 2/5] net: macb: Fix coding style warnings Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
[PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
Re: [PATCH 0/5] net: macb: Checkpatch cleanups Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
Re: [PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-16 17:40 +0100
csiph-web