Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358998

Re: [PATCH 2/5] net: macb: Fix coding style warnings

Show all headers | View raw

Le 14/03/2016 21:53, Michal Simek a écrit :
> On 13.3.2016 20:10, Moritz Fischer wrote:
>> This commit takes care of the coding style warnings
>> that are mostly due to a different comment style and
>> lines over 80 chars, as well as a dangling else.
>>
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>>  drivers/net/ethernet/cadence/macb.c | 101 +++++++++++++++---------------------
>>  1 file changed, 43 insertions(+), 58 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index 4370f37..c2d31c5 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -58,8 +58,7 @@
>>  
>>  #define GEM_MTU_MIN_SIZE	68
>>  
>> -/*
>> - * Graceful stop timeouts in us. We should allow up to
>> +/* Graceful stop timeouts in us. We should allow up to
>>   * 1 frame time (10 Mbits/s, full-duplex, ignoring collisions)
>>   */
>>  #define MACB_HALT_TIMEOUT	1230
>> @@ -127,8 +126,7 @@ static void hw_writel(struct macb *bp, int offset, u32 value)
>>  	writel_relaxed(value, bp->regs + offset);
>>  }
>>  
>> -/*
>> - * Find the CPU endianness by using the loopback bit of NCR register. When the
>> +/* Find the CPU endianness by using the loopback bit of NCR register. When the
> 
> TBH: I would rather see this converting to kernel-doc format instead of
> using this networking block.

As there is hardly any kernel-doc comments in this driver, I won't force
Moritz to move this one to it.

I would advice, if someone want to move to kernel-doc for some function
comments, to do it in a separate patch (series).


> Also splitting this to more patches will be better. Just by categories
> but that's just my opinion.

Well, yes... but I won't be too picky for such a patch. So here is my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thank for your feedback, bye,
-- 
Nicolas Ferre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
  [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
    Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
    Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
  [PATCH 5/5] net: macb: Fix simple typo. Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
    Re: [PATCH 5/5] net: macb: Fix simple typo. Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
      Re: [PATCH 5/5] net: macb: Fix simple typo. Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 15:00 +0100
  [PATCH 1/5] net: macb: Fix coding style error message Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
    Re: [PATCH 1/5] net: macb: Fix coding style error message Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
    Re: [PATCH 1/5] net: macb: Fix coding style error message Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:40 +0100
  [PATCH 2/5] net: macb: Fix coding style warnings Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
    Re: [PATCH 2/5] net: macb: Fix coding style warnings Michal Simek <michal.simek@xilinx.com> - 2016-03-14 22:00 +0100
      Re: [PATCH 2/5] net: macb: Fix coding style warnings Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
  [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
    Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
    Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
  Re: [PATCH 0/5] net: macb: Checkpatch cleanups Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
    Re: [PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-16 17:40 +0100

csiph-web