Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357612
| From | Michal Simek <michal.simek@xilinx.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy |
| Date | 2016-03-14 21:50 +0100 |
| Message-ID | <rcHB7-pu-1@gated-at.bofh.it> (permalink) |
| References | <rcjIt-1tp-1@gated-at.bofh.it> <rcjIu-1tp-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 13.3.2016 20:10, Moritz Fischer wrote: > Checkpatch suggests using ether_addr_copy over memcpy > to copy the mac address. > > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 53400f6..a0c01e5 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2891,7 +2891,7 @@ static int macb_probe(struct platform_device *pdev) > > mac = of_get_mac_address(np); > if (mac) > - memcpy(bp->dev->dev_addr, mac, ETH_ALEN); > + ether_addr_copy(bp->dev->dev_addr, mac); > else > macb_get_hwaddr(bp); > > Acked-by: Michal Simek <michal.simek@xilinx.com> M
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
[PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
[PATCH 5/5] net: macb: Fix simple typo. Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 5/5] net: macb: Fix simple typo. Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 5/5] net: macb: Fix simple typo. Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 15:00 +0100
[PATCH 1/5] net: macb: Fix coding style error message Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 1/5] net: macb: Fix coding style error message Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 1/5] net: macb: Fix coding style error message Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:40 +0100
[PATCH 2/5] net: macb: Fix coding style warnings Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 2/5] net: macb: Fix coding style warnings Michal Simek <michal.simek@xilinx.com> - 2016-03-14 22:00 +0100
Re: [PATCH 2/5] net: macb: Fix coding style warnings Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
[PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-13 20:20 +0100
Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Michal Simek <michal.simek@xilinx.com> - 2016-03-14 21:50 +0100
Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
Re: [PATCH 0/5] net: macb: Checkpatch cleanups Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-16 14:50 +0100
Re: [PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer <moritz.fischer@ettus.com> - 2016-03-16 17:40 +0100
csiph-web