Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437701

Re: [PATCH] pinctrl: imx21: include linux/module.h

Show all headers | View raw

Hi Arnd,

On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The pinctrl driver includes a device table, but the macro used for
> declaring it is declared in a header that is not visible here:
>
> drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
>  MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
>
> This adds the missing include.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")

I think the correct fix here would be:

--- a/drivers/pinctrl/freescale/pinctrl-imx21.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
@@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
        { .compatible = "fsl,imx21-iomuxc", },
        { }
 };
-MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);

 static struct platform_driver imx21_pinctrl_driver = {
        .driver = {


If you agree I can send a formal patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:00 +0200
  Re: [PATCH] pinctrl: imx21: include linux/module.h Fabio Estevam <festevam@gmail.com> - 2016-07-06 15:20 +0200
    Re: [PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:20 +0200
    Re: [PATCH] pinctrl: imx21: include linux/module.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-06 15:30 +0200
      Re: [PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:50 +0200

csiph-web