Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1437700

Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular

From Neil Armstrong <narmstrong@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular
Date 2016-07-06 15:20 +0200
Message-ID <rRUU9-1e4-7@gated-at.bofh.it> (permalink)
References <rRjrz-2ik-3@gated-at.bofh.it> <rRjrz-2ik-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2016-07-04 23:12 GMT+02:00 Paul Gortmaker <paul.gortmaker@windriver.com>:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/clk/Kconfig:config COMMON_CLK_OXNAS
> drivers/clk/Kconfig:    bool "Clock driver for the OXNAS SoC Family"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/clk/clk-oxnas.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
>

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/10] clk: fix/remove module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
  [PATCH 03/10] clk: mvebu: make cp110-system-controller explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
  [PATCH 02/10] clk: meson: make gxbb explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 02/10] clk: meson: make gxbb explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-05 11:10 +0200
      Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-05 15:40 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-05 13:10 +0200
      Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-05 15:20 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-07 15:20 +0200
  [PATCH 01/10] clk: meson8b: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 01/10] clk: meson8b: make it explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-04 23:40 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-05 08:20 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 05/10] clk: oxnas: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular Neil Armstrong <narmstrong@baylibre.com> - 2016-07-06 15:20 +0200
    Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200

csiph-web