Re: [PATCH] pinctrl: imx21: include linux/module.h

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: imx21: include linux/module.h
Date	2016-07-06 15:50 +0200
Message-ID	<rRVnc-1pJ-17@gated-at.bofh.it> (permalink)
References	<rRUAN-Sa-9@gated-at.bofh.it> <rRUU9-1e4-9@gated-at.bofh.it> <rRV3Q-1jb-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
> >         { .compatible = "fsl,imx21-iomuxc", },
> >         { }
> >  };
> > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> > 
> >  static struct platform_driver imx21_pinctrl_driver = {
> >         .driver = {
> > 
> > 
> > If you agree I can send a formal patch.
> 
> Yes, deleting the MODULE_DEVICE_TABLE is the right fix.  I'm curious why
> that never showed up in all the build coverage I did...

I needed several hundred randconfig builds before hitting it, I think
it's just rare because the driver is not enabled most of the time, and
it's possible that the header sometimes gets included implicitly.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:00 +0200
  Re: [PATCH] pinctrl: imx21: include linux/module.h Fabio Estevam <festevam@gmail.com> - 2016-07-06 15:20 +0200
    Re: [PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:20 +0200
    Re: [PATCH] pinctrl: imx21: include linux/module.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-06 15:30 +0200
      Re: [PATCH] pinctrl: imx21: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2016-07-06 15:50 +0200

csiph-web