Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

From	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()
Date	2016-06-28 22:00 +0200
Message-ID	<rP7kR-2R4-9@gated-at.bofh.it> (permalink)
References	<rOAfg-6cY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 27, 2016 at 04:33:24PM +0800, Bob Liu wrote:
> Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() during
> migration, but that's too later after multi-queue introduced.
> 
> After a migrate to another host (which may not have multiqueue support), the
> number of rings (block hardware queues) may be changed and the ring and shadow
> structure will also be reallocated.
> So that blkfront_recover() can't 'save and resubmit' the real uncompleted reqs
> because shadow structure has been reallocated.
> 
> This patch fixes this issue by moving the 'save and resubmit' logic out of
> blkfront_recover() to earlier place:blkfront_resume().
> 
> Signed-off-by: Bob Liu <bob.liu@oracle.com>

Ack-ed and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Let me run it through some tests and if no regressions found I will 
ask Jens to pull it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Bob Liu <bob.liu@oracle.com> - 2016-06-27 10:40 +0200
  Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Bob Liu <bob.liu@oracle.com> - 2016-06-27 15:40 +0200
  Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-06-28 22:00 +0200

csiph-web