Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1433257

Re: [PATCH] Drivers: block: fixed a code style issue

From kbuild test robot <lkp@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Drivers: block: fixed a code style issue
Date 2016-06-28 22:00 +0200
Message-ID <rP7kR-2R4-3@gated-at.bofh.it> (permalink)
References <rP6oO-2h2-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi,

[auto build test WARNING on v4.7-rc5]
[also build test WARNING on next-20160628]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Saidgani-Musaev/Drivers-block-fixed-a-code-style-issue/20160629-025927
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   drivers/block/loop.c: In function 'max_loop_setup':
>> drivers/block/loop.c:2055:13: warning: passing argument 2 of 'kstrtol' makes integer from pointer without a cast
     max_loop = kstrtol(str, NULL, 0);
                ^
   In file included from include/linux/list.h:8:0,
                    from include/linux/module.h:9,
                    from drivers/block/loop.c:52:
   include/linux/kernel.h:327:32: note: expected 'unsigned int' but argument is of type 'void *'
    static inline int __must_check kstrtol(const char *s, unsigned int base, long *res)
                                   ^

vim +/kstrtol +2055 drivers/block/loop.c

  2039	
  2040		idr_for_each(&loop_index_idr, &loop_exit_cb, NULL);
  2041		idr_destroy(&loop_index_idr);
  2042	
  2043		blk_unregister_region(MKDEV(LOOP_MAJOR, 0), range);
  2044		unregister_blkdev(LOOP_MAJOR, "loop");
  2045	
  2046		misc_deregister(&loop_misc);
  2047	}
  2048	
  2049	module_init(loop_init);
  2050	module_exit(loop_exit);
  2051	
  2052	#ifndef MODULE
  2053	static int __init max_loop_setup(char *str)
  2054	{
> 2055		max_loop = kstrtol(str, NULL, 0);
  2056		return 1;
  2057	}
  2058	
  2059	__setup("max_loop=", max_loop_setup);
  2060	#endif

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Drivers: block: fixed a code style issue Saidgani Musaev <cpu808694@gmail.com> - 2016-06-28 21:00 +0200
  Re: [PATCH] Drivers: block: fixed a code style issue kbuild test robot <lkp@intel.com> - 2016-06-28 22:00 +0200
  Re: [PATCH] Drivers: block: fixed a code style issue kbuild test robot <lkp@intel.com> - 2016-06-28 22:10 +0200

csiph-web