Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433258
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() |
| Date | Tue, 28 Jun 2016 22:00:01 +0200 |
| Message-ID | <rP7kR-2R4-9@gated-at.bofh.it> (permalink) |
| References | <rOAfg-6cY-9@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| X-Source-IP | userp1040.oracle.com [156.151.31.81] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com |
| X-Original-Date | Tue, 28 Jun 2016 15:53:26 -0400 |
| X-Original-Message-ID | <20160628195325.GA14723@char.us.oracle.com> |
| X-Original-References | <1467016404-7883-1-git-send-email-bob.liu@oracle.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1433258 |
Show key headers only | View raw
On Mon, Jun 27, 2016 at 04:33:24PM +0800, Bob Liu wrote: > Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() during > migration, but that's too later after multi-queue introduced. > > After a migrate to another host (which may not have multiqueue support), the > number of rings (block hardware queues) may be changed and the ring and shadow > structure will also be reallocated. > So that blkfront_recover() can't 'save and resubmit' the real uncompleted reqs > because shadow structure has been reallocated. > > This patch fixes this issue by moving the 'save and resubmit' logic out of > blkfront_recover() to earlier place:blkfront_resume(). > > Signed-off-by: Bob Liu <bob.liu@oracle.com> Ack-ed and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Let me run it through some tests and if no regressions found I will ask Jens to pull it.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Bob Liu <bob.liu@oracle.com> - 2016-06-27 10:40 +0200 Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Bob Liu <bob.liu@oracle.com> - 2016-06-27 15:40 +0200 Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-06-28 22:00 +0200
csiph-web