Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423645

Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

Show all headers | View raw

On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown <broonie@kernel.org> wrote:
>> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote:
>>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote:
>>
>>> > +sound {
>>> > +   compatible = "rockchip,rk3399-gru-sound";
>>> > +   rockchip,cpu = <&i2s0>;
>>> > +   rockchip,codec = <&max98357a &rt5514 &da7219>;
>>
>>> These seem fairly standard though a variety of versions in the bindings.
>>> Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark?
>>
>> Well, the roles aren't actually that standard (the fact that there's
>> multiple CODECs and one CPU DAI here is really odd and definitely needs
>> a very system specific interpretation).  If they were standard we
>> already have the simple-card binding that things should be using.
>> There's no point in standard property names if the interpretation has to
>> be non-standard.
>
> Okay, I agree with the system specific interpretation part. However, I
> don't think using simple-card or not determines using common
> properties.
>

Hi Mark, I have a question for the one CPU DAI + multiple CODECs
setup. The machine driver defines 3 DAI links, connecting the same CPU
DAI to 3 different CODEC DAIs. Does ASoC/DAPM support
enabling/disabling an individual DAI link based on the status of the
endpoint widget (e.g. DAPM_SPK) connected to the corresponding CODEC?

The goal is to let user select either headphone(da7219) or
speaker(max98357a) as output. max98357a driver does not expose a
kcontrol for mute. It sets a shutdown GPIO on PCM_TRIGGER_START/STOP.
And it seems soc_pcm_trigger calls the trigger op of all 3 CODEC DAIs,
even when the DAPM_SPK widget is disabled by its pin switch.

>> The vendor specific prefixes are there because all bindings are supposed
>> to add prefixes to property names.
>
> ...unless they are common.
>
> Rob
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Thanks,
Ben

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-13 10:50 +0200
  Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Rob Herring <robh@kernel.org> - 2016-06-15 00:40 +0200
    Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Mark Brown <broonie@kernel.org> - 2016-06-15 12:00 +0200
      Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Rob Herring <robh@kernel.org> - 2016-06-15 14:50 +0200
        Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for  RK3399 GRU Boards Ben Zhang <benzh@chromium.org> - 2016-06-16 04:40 +0200
        Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
  Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Steve Barber <smbarber@google.com> - 2016-06-15 21:50 +0200
    Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-16 03:20 +0200
      RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-06-16 10:50 +0200

csiph-web