Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422843
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards |
| Date | 2016-06-15 12:00 +0200 |
| Message-ID | <rKfM5-Te-3@gated-at.bofh.it> (permalink) |
| References | <rJvJg-3OU-49@gated-at.bofh.it> <rK5a1-2vN-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote:
> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote:
> > +sound {
> > + compatible = "rockchip,rk3399-gru-sound";
> > + rockchip,cpu = <&i2s0>;
> > + rockchip,codec = <&max98357a &rt5514 &da7219>;
> These seem fairly standard though a variety of versions in the bindings.
> Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark?
Well, the roles aren't actually that standard (the fact that there's
multiple CODECs and one CPU DAI here is really odd and definitely needs
a very system specific interpretation). If they were standard we
already have the simple-card binding that things should be using.
There's no point in standard property names if the interpretation has to
be non-standard.
The vendor specific prefixes are there because all bindings are supposed
to add prefixes to property names.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-13 10:50 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Rob Herring <robh@kernel.org> - 2016-06-15 00:40 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Mark Brown <broonie@kernel.org> - 2016-06-15 12:00 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Rob Herring <robh@kernel.org> - 2016-06-15 14:50 +0200
Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Ben Zhang <benzh@chromium.org> - 2016-06-16 04:40 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Steve Barber <smbarber@google.com> - 2016-06-15 21:50 +0200
Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-16 03:20 +0200
RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-06-16 10:50 +0200
csiph-web