RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

From	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
Date	2016-06-16 10:50 +0200
Message-ID	<rKB9T-62Y-3@gated-at.bofh.it> (permalink)
References	<rJvJg-3OU-49@gated-at.bofh.it> <rKoZ3-6Iv-3@gated-at.bofh.it> <rKu8q-1IJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16 June 2016 02:15, Xing Zheng wrote:

> >> +       /* Enable Headset and 4 Buttons Jack detection */
> >> +       ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
> >> +                                   SND_JACK_HEADSET |
> > Should this also include SND_JACK_LINEOUT? da7219 differentiates
> > between the two so not including lineout means, for example, we can
> > miss jack insertion/removal events.
> >
> Hi Adam,
> 
> Could you please confirm Steve says that about SND_JACK_LINEOUT?
> 
> Thanks.

Hi Xing Zheng,

Yes, as Steve mentioned DA7219 does support SND_JACK_LINEOUT so we should really
include this here.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-13 10:50 +0200
  Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Rob Herring <robh@kernel.org> - 2016-06-15 00:40 +0200
    Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Mark Brown <broonie@kernel.org> - 2016-06-15 12:00 +0200
      Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Rob Herring <robh@kernel.org> - 2016-06-15 14:50 +0200
        Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for  RK3399 GRU Boards Ben Zhang <benzh@chromium.org> - 2016-06-16 04:40 +0200
        Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Mark Brown <broonie@kernel.org> - 2016-06-17 14:30 +0200
  Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Steve Barber <smbarber@google.com> - 2016-06-15 21:50 +0200
    Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards Xing Zheng <zhengxing@rock-chips.com> - 2016-06-16 03:20 +0200
      RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU  Boards "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-06-16 10:50 +0200

csiph-web