Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419299
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V2 04/11] net: mediatek: dropped rx packets are not being counted properly |
| Date | 2016-06-10 13:40 +0200 |
| Message-ID | <rIsX8-3Yr-35@gated-at.bofh.it> (permalink) |
| References | <rIsNs-3Vg-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
There are two places inside mtk_poll_rx where rx_dropped is not being
incremented properly. Fix this by adding the missing code to increment
the counter.
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 4f22ee9..0610262 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -810,6 +810,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
DMA_FROM_DEVICE);
if (unlikely(dma_mapping_error(&netdev->dev, dma_addr))) {
skb_free_frag(new_data);
+ netdev->stats.rx_dropped++;
goto release_desc;
}
@@ -817,6 +818,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
skb = build_skb(data, ring->frag_size);
if (unlikely(!skb)) {
put_page(virt_to_head_page(new_data));
+ netdev->stats.rx_dropped++;
goto release_desc;
}
skb_reserve(skb, NET_SKB_PAD + NET_IP_ALIGN);
--
1.7.10.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 05/11] net: mediatek: add next data pointer coherency protection John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 06/11] net: mediatek: disable all interrupts during probe John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-10 19:50 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 20:00 +0200
[PATCH V2 10/11] net: mediatek: only wake the queue if it is stopped John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 01/11] net: mediatek: add missing return code check John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 04/11] net: mediatek: dropped rx packets are not being counted properly John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-11 08:40 +0200
csiph-web