Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419288
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V2 05/11] net: mediatek: add next data pointer coherency protection |
| Date | 2016-06-10 13:40 +0200 |
| Message-ID | <rIsX8-3Yr-15@gated-at.bofh.it> (permalink) |
| References | <rIsNs-3Vg-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The QDMA engine can fail to update the register pointing to the next TX descriptor if this bit does not get set in the QDMA configuration register. Not setting this bit can result in invalid values inside the TX rings registers which will causes TX stalls. Signed-off-by: John Crispin <john@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 0610262..bfac376 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1261,7 +1261,7 @@ static int mtk_start_dma(struct mtk_eth *eth) mtk_w32(eth, MTK_TX_WB_DDONE | MTK_RX_DMA_EN | MTK_TX_DMA_EN | MTK_RX_2B_OFFSET | MTK_DMA_SIZE_16DWORDS | - MTK_RX_BT_32DWORDS, + MTK_RX_BT_32DWORDS | MTK_NDP_CO_PRO, MTK_QDMA_GLO_CFG); return 0; diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h index 57f7e8a..a5eb7c6 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -91,6 +91,7 @@ #define MTK_QDMA_GLO_CFG 0x1A04 #define MTK_RX_2B_OFFSET BIT(31) #define MTK_RX_BT_32DWORDS (3 << 11) +#define MTK_NDP_CO_PRO BIT(10) #define MTK_TX_WB_DDONE BIT(6) #define MTK_DMA_SIZE_16DWORDS (2 << 4) #define MTK_RX_DMA_BUSY BIT(3) -- 1.7.10.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 05/11] net: mediatek: add next data pointer coherency protection John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 06/11] net: mediatek: disable all interrupts during probe John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-10 19:50 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 20:00 +0200
[PATCH V2 10/11] net: mediatek: only wake the queue if it is stopped John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 01/11] net: mediatek: add missing return code check John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 04/11] net: mediatek: dropped rx packets are not being counted properly John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-11 08:40 +0200
csiph-web