Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419289
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V2 06/11] net: mediatek: disable all interrupts during probe |
| Date | 2016-06-10 13:40 +0200 |
| Message-ID | <rIsX7-3Yr-5@gated-at.bofh.it> (permalink) |
| References | <rIsNs-3Vg-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The current code only disables those IRQs that we will later use. To ensure that we have a predefined state, we really want to disable all IRQs. Change the code to disable all IRQs to achieve this. Signed-off-by: John Crispin <john@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index bfac376..93af4e3 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1375,7 +1375,7 @@ static int __init mtk_hw_init(struct mtk_eth *eth) /* disable delay and normal interrupt */ mtk_w32(eth, 0, MTK_QDMA_DELAY_INT); - mtk_irq_disable(eth, MTK_TX_DONE_INT | MTK_RX_DONE_INT); + mtk_irq_disable(eth, ~0); mtk_w32(eth, RST_GL_PSE, MTK_RST_GL); mtk_w32(eth, 0, MTK_RST_GL); -- 1.7.10.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 05/11] net: mediatek: add next data pointer coherency protection John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 06/11] net: mediatek: disable all interrupts during probe John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-10 19:50 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-10 20:00 +0200
[PATCH V2 10/11] net: mediatek: only wake the queue if it is stopped John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 01/11] net: mediatek: add missing return code check John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
[PATCH V2 04/11] net: mediatek: dropped rx packets are not being counted properly John Crispin <john@phrozen.org> - 2016-06-10 13:40 +0200
Re: [PATCH V2 00/11] net: mediatek: various small fixes David Miller <davem@davemloft.net> - 2016-06-11 08:40 +0200
csiph-web