Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs
Date	2016-06-08 11:10 +0200
Message-ID	<rHHES-6Fd-39@gated-at.bofh.it> (permalink)
References	<rHyLf-GT-5@gated-at.bofh.it> <rHyLf-GT-19@gated-at.bofh.it> <rHGz8-5Mb-19@gated-at.bofh.it> <rHH29-6b9-5@gated-at.bofh.it> <rHHvc-6mU-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/08/16 01:28, Ingo Molnar wrote:
> > 
> > It does matter:
> > 
> >  In file included from arch/x86/kernel/cpu/common.c:21:0:
> >  ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of ‘arch_get_random_long’
> >  static inline bool arch_get_random_long(unsigned long *v)
> >  In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
> >  include/linux/random.h:98:20: note: previous definition of ‘arch_get_random_long’ was here
> > 
> 
> Actually this is an indication of a major bug, quite possibly
> pre-existing; we somehow are trying to include both the stub and the
> non-stub version of arch_get_random_long(), which is an obvious no-no.

Yeah.

> I will look at it in the morning (02:00 here.)

Sure, take your time! I've rewinded x86/asm to 08dd8cd06ed9 for the time being.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs "H. Peter Anvin" <hpa@linux.intel.com> - 2016-06-08 01:40 +0200
  [tip:x86/asm] x86, asm: use bool for bitops and other assembly  outputs "tip-bot for H. Peter Anvin" <tipbot@zytor.com> - 2016-06-08 01:50 +0200
  Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 10:00 +0200
    Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:30 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:40 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
          Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200
            Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:20 +0200
              Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:30 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:40 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200

csiph-web