Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs
Date	2016-06-08 11:10 +0200
Message-ID	<rHHER-6Fd-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rHyLf-GT-19@gated-at.bofh.it> <rHGz8-5Mb-19@gated-at.bofh.it> <rHH29-6b9-5@gated-at.bofh.it> <rHHbQ-6et-11@gated-at.bofh.it> <rHHvc-6mU-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/08/16 01:33, Ingo Molnar wrote:
> > 
> > Note that this particular build error was introduced by b0bdba9825fe, a later 
> > patch in this series - but in generaly I'm uneasy about allowing function 
> > signatures diverge between architectures.
> > 
> 
> For the bitops, they already do: PowerPC, for example, have "unsigned
> long" in places where x86 has "int".  This is obviously undesirable, but
> apparently we have not found it enough of a problem to deal with.
>
> One could easily argue the ppc definition is the better one; I was myself 
> considering promoting the x86 side to "long" to handle enormous bitmaps. At the 
> same time, it is hard to avoid the fact that ppc has unsigned bitops operations 
> and x86 has signed ones when they are both native instructions.

That's a divergence with an underlying reason - but not harmonizing the return 
code is an unforced error AFAICS and can be fixed.

Thanks,

	Ingo

Thread

[PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs "H. Peter Anvin" <hpa@linux.intel.com> - 2016-06-08 01:40 +0200
  [tip:x86/asm] x86, asm: use bool for bitops and other assembly  outputs "tip-bot for H. Peter Anvin" <tipbot@zytor.com> - 2016-06-08 01:50 +0200
  Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 10:00 +0200
    Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:30 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:40 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
          Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200
            Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:20 +0200
              Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:30 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:40 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200

csiph-web