Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs
Date	2016-06-08 10:30 +0200
Message-ID	<rHH29-6b9-5@gated-at.bofh.it> (permalink)
References	<rHyLf-GT-5@gated-at.bofh.it> <rHyLf-GT-19@gated-at.bofh.it> <rHGz8-5Mb-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Jun 07, 2016 at 04:31:01PM -0700, H. Peter Anvin wrote:
> > From: "H. Peter Anvin" <hpa@zytor.com>
> > 
> > The gcc people have confirmed that using "bool" when combined with
> > inline assembly always is treated as a byte-sized operand that can be
> > assumed to be 0 or 1, which is exactly what the SET instruction
> > emits.  Change the output types and intermediate variables of as many
> > operations as practical to "bool".
> > 
> > Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> > ---
> >  arch/x86/boot/bitops.h             |  8 +++++---
> >  arch/x86/boot/boot.h               |  8 ++++----
> >  arch/x86/boot/string.c             |  2 +-
> >  arch/x86/include/asm/apm.h         |  6 +++---
> >  arch/x86/include/asm/archrandom.h  | 16 ++++++++--------
> >  arch/x86/include/asm/atomic.h      |  8 ++++----
> >  arch/x86/include/asm/atomic64_64.h | 10 +++++-----
> >  arch/x86/include/asm/bitops.h      | 28 ++++++++++++++--------------
> >  arch/x86/include/asm/local.h       |  8 ++++----
> >  arch/x86/include/asm/percpu.h      |  8 ++++----
> >  arch/x86/include/asm/rmwcc.h       |  4 ++--
> >  arch/x86/include/asm/rwsem.h       | 17 +++++++++--------
> >  include/linux/random.h             | 12 ++++++------
> >  13 files changed, 69 insertions(+), 66 deletions(-)
> 
> So the only concern I have with this is that the x86 function signatures
> are now different from the other architectures.
> 
> Not sure how much if anything that matters..

It does matter:

 In file included from arch/x86/kernel/cpu/common.c:21:0:
 ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of ‘arch_get_random_long’
 static inline bool arch_get_random_long(unsigned long *v)
 In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
 include/linux/random.h:98:20: note: previous definition of ‘arch_get_random_long’ was here

Thanks,

	Ingo

Thread

[PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs "H. Peter Anvin" <hpa@linux.intel.com> - 2016-06-08 01:40 +0200
  [tip:x86/asm] x86, asm: use bool for bitops and other assembly  outputs "tip-bot for H. Peter Anvin" <tipbot@zytor.com> - 2016-06-08 01:50 +0200
  Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 10:00 +0200
    Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:30 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:40 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
          Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200
            Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:20 +0200
              Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:30 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:40 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Peter Zijlstra <peterz@infradead.org> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
                Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:50 +0200
      Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs "H. Peter Anvin" <hpa@zytor.com> - 2016-06-08 11:00 +0200
        Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly  outputs Ingo Molnar <mingo@kernel.org> - 2016-06-08 11:10 +0200

csiph-web