Re: [PATCH v8 2/4] GCC plugin infrastructure

From	Emese Revfy <re.emese@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 2/4] GCC plugin infrastructure
Date	2016-05-18 12:50 +0200
Message-ID	<rA7d7-WC-17@gated-at.bofh.it> (permalink)
References	<ry8wG-81C-3@gated-at.bofh.it> <ry8Gm-868-5@gated-at.bofh.it> <rzOat-5Hf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 17 May 2016 16:28:05 +0200
Michal Marek <mmarek@suse.com> wrote:

> Dne 13.5.2016 v 01:57 Emese Revfy napsal(a):
> > --- /dev/null
> > +++ b/scripts/Makefile.gcc-plugins
> > @@ -0,0 +1,21 @@
> > +ifdef CONFIG_GCC_PLUGINS
> > +  __PLUGINCC := $(call cc-ifversion, -ge, 0408, $(HOSTCXX), $(HOSTCC))
> > +  PLUGINCC := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-plugin.sh "$(__PLUGINCC)" "$(HOSTCXX)" "$(CC)")
> > +
> > +  GCC_PLUGINS_CFLAGS := $(addprefix -fplugin=$(objtree)/scripts/gcc-plugins/, $(gcc-plugin-y))
> > +
> > +  ifeq ($(PLUGINCC),)
> > +    ifneq ($(GCC_PLUGINS_CFLAGS),)
> > +      ifeq ($(call cc-ifversion, -ge, 0405, y), y)
> > +        PLUGINCC := $(shell $(CO, NFIG_SHELL) -x $(srctree)/scripts/gcc-plugin.sh "$(__PLUGINCC)" "$(HOSTCXX)" "$(CC)")
> > +        $(error error, your gcc installation does not support plugins, perhaps the necessary headers are missing?)
> > +      else
> > +        $(error error, your gcc version does not support plugins, you should upgrade it to gcc 4.5 at least)
> > +      endif
> > +    endif
> > +  endif
> > +
> > +  KBUILD_CFLAGS += $(GCC_PLUGINS_CFLAGS)
> > +  GCC_PLUGIN := $(gcc-plugin-y)
> > +
> > +endif
> 
> Hi Emese,
> 
> sorry for the late feedback. A problem I ran into now is that if you
> have a compiler that is either too old or built with plugin support
> disabled, scripts/Makefile.gcc-plugins errors out immediately. This is
> going to be an issue with allmodconfig/allyesconfig test builds. A
> solution would either be to make the respective options depend on
> !COMPILE_TEST, or turn the errors into warnings and do nothing if the
> compiler lacks plugin support. We are handling CONFIG_CC_STACKPROTECTOR
> on x86 this way already.

Hi,

I'll change the errors to warnings in the next patch set.

-- 
Emese

Thread

[PATCH v8 0/4] Introduce GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-13 01:50 +0200
  [PATCH v8 4/4] Add sancov plugin Emese Revfy <re.emese@gmail.com> - 2016-05-13 02:00 +0200
  [PATCH v8 3/4] Add Cyclomatic complexity GCC plugin Emese Revfy <re.emese@gmail.com> - 2016-05-13 02:00 +0200
    Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC  plugin Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 10:30 +0200
      Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC  plugin Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:50 +0200
  Re: [PATCH v8 2/4] GCC plugin infrastructure Michal Marek <mmarek@suse.com> - 2016-05-17 16:30 +0200
    Re: [PATCH v8 2/4] GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:50 +0200
  Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 11:00 +0200
    Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:30 +0200
      Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 23:20 +0200
      Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Michael Ellerman <mpe@ellerman.id.au> - 2016-05-19 08:30 +0200
        Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-19 08:50 +0200
        Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure "PaX Team" <pageexec@freemail.hu> - 2016-05-19 10:50 +0200
          Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-20 08:30 +0200
          Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Michael Ellerman <mpe@ellerman.id.au> - 2016-05-20 12:20 +0200

csiph-web