Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure
Date	2016-05-19 08:30 +0200
Message-ID	<rApD3-4yo-1@gated-at.bofh.it> (permalink)
References	<ry8wG-81C-3@gated-at.bofh.it> <ry8Gm-868-5@gated-at.bofh.it> <rA5uF-8b8-19@gated-at.bofh.it> <rA6TN-Pd-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-05-18 at 12:33 +0200, Emese Revfy wrote:

> > I've done some basic sanity testing on powerpc with the cyclomatic 
> > complexity plugin (with LE native + cross-compilers) and it seems to 
> > work with the patch below.
> > 
> > Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> > 
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index a18a0dc..0cfed5b 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -97,6 +97,7 @@ config PPC
> >          select HAVE_DYNAMIC_FTRACE_WITH_REGS if MPROFILE_KERNEL
> >          select HAVE_FUNCTION_TRACER
> >          select HAVE_FUNCTION_GRAPH_TRACER
> > +       select HAVE_GCC_PLUGINS
> >          select SYSCTL_EXCEPTION_TRACE
> >          select ARCH_WANT_OPTIONAL_GPIOLIB
> >          select VIRT_TO_BUS if !PPC64
> 
> Hi,
> 
> Did you test the plugins with all gcc versions (4.5-6)?

What's the concern about gcc versions? Just not breaking the build on old
compilers?

I'm pretty sure powerpc big endian still builds with gcc 4.4.

However if Andrew's only tested on little endian, then that select should be
guarded with an "if CPU_LITTLE_ENDIAN". And to build LE you need gcc >= 4.9.

cheers

Thread

[PATCH v8 0/4] Introduce GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-13 01:50 +0200
  [PATCH v8 4/4] Add sancov plugin Emese Revfy <re.emese@gmail.com> - 2016-05-13 02:00 +0200
  [PATCH v8 3/4] Add Cyclomatic complexity GCC plugin Emese Revfy <re.emese@gmail.com> - 2016-05-13 02:00 +0200
    Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC  plugin Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 10:30 +0200
      Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC  plugin Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:50 +0200
  Re: [PATCH v8 2/4] GCC plugin infrastructure Michal Marek <mmarek@suse.com> - 2016-05-17 16:30 +0200
    Re: [PATCH v8 2/4] GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:50 +0200
  Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 11:00 +0200
    Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Emese Revfy <re.emese@gmail.com> - 2016-05-18 12:30 +0200
      Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-18 23:20 +0200
      Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Michael Ellerman <mpe@ellerman.id.au> - 2016-05-19 08:30 +0200
        Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-19 08:50 +0200
        Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure "PaX Team" <pageexec@freemail.hu> - 2016-05-19 10:50 +0200
          Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-05-20 08:30 +0200
          Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure Michael Ellerman <mpe@ellerman.id.au> - 2016-05-20 12:20 +0200

csiph-web