Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341159

Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error

Show all headers | View raw

On 2/23/16 6:11 AM, Borislav Petkov wrote:
> On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote:
>>   /* AMD-specific bits */
>> -#define MCI_STATUS_DEFERRED	(1ULL<<44)  /* declare an uncorrected error */
>> +#define MCI_STATUS_DEFERRED	(1ULL<<44)  /* declare a deferred error */
> /* uncorrected error, deferred exception */
>
> sounds better to me.

Hmm. Well, Deferred error is a separate class of error by itself.
It's neither Corrected in HW nor is it Uncorrected like a MCE.

If you feel "Uncorrected error, deferred error exception" won;t be 
confusing, that's OK with me.


>
> For the future, such cleanups/fixes should always go first in the patch
> set.
>

Ok, I'll retain the order this time for V2 patchset as well.
But noted for future.

Thanks,
-Aravind.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Borislav Petkov <bp@alien8.de> - 2016-02-23 13:20 +0100
  Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com> - 2016-02-24 00:20 +0100
    Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Borislav Petkov <bp@alien8.de> - 2016-02-24 12:40 +0100
      Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Boris Petkov <bp@alien8.de> - 2016-02-24 21:40 +0100

csiph-web