Re: [PATCH] rtc: s5m: De-inline large functions to save space

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: s5m: De-inline large functions to save space
Date	2016-02-24 00:20 +0100
Message-ID	<r5upk-47T-7@gated-at.bofh.it> (permalink)
References	<r2Dfr-1dj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/02/2016 at 11:04:42 +0900, Krzysztof Kozlowski wrote :
> Few functions were marked inline even though they were relatively large
> and sometimes used in multiple places. De-inline them to let the
> compiler decide whether optimization makes sense. This fixes inline_hunt
> report:
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes
> 
> Reported-by: Denys Vlasenko <vda.linux@googlemail.com>
> Cc: Denys Vlasenko <vda.linux@googlemail.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/rtc/rtc-s5m.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] rtc: s5m: De-inline large functions to save space Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-24 00:20 +0100

csiph-web