Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336565

Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups

From Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups
Date 2016-02-17 17:30 +0100
Message-ID <r3d9l-uB-111@gated-at.bofh.it> (permalink)
References <r3cwx-8pl-7@gated-at.bofh.it> <r3cZz-oW-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, 17 Feb, at 05:08:57PM, Thomas Gleixner wrote:
> On Wed, 17 Feb 2016, Thomas Gleixner wrote:
> 
> > CQM is a strict per package facility. Use the proper cpumasks to lookup the
> > readers.
> 
> Sorry for the noise. PEBKAC: quilt refresh missing. Correct version below.
> 
> Thanks,
> 
> 	tglx
> 
> 8<----------
> 
> Subject: x86/perf/cqm: Get rid of the silly for_each_cpu lookups
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Sun, 14 Feb 2016 23:09:06 +0100
> 
> CQM is a strict per package facility. Use the proper cpumasks to lookup the
> readers.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_cqm.c |   34 ++++++++++-------------------
>  1 file changed, 12 insertions(+), 22 deletions(-)

Right, I just could not make the connection between
topology_core_cpumask() and topology_physical_package_id() when I
wrote this code.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 16:50 +0100
  Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 17:20 +0100
    Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-17 17:30 +0100
    Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-17 19:30 +0100
      Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 19:40 +0100
      Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 19:40 +0100
        Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-17 19:50 +0100
          Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 20:20 +0100
            Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-18 21:20 +0100
              Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-19 00:20 +0100

csiph-web