Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups
Date	2016-02-17 19:40 +0100
Message-ID	<r3fb4-1S3-19@gated-at.bofh.it> (permalink)
References	<r3cwx-8pl-7@gated-at.bofh.it> <r3cZz-oW-1@gated-at.bofh.it> <r3f1p-1O1-35@gated-at.bofh.it> <r3fb4-1S3-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 17 Feb 2016, Thomas Gleixner wrote:

> On Wed, 17 Feb 2016, Vikas Shivappa wrote:
> > > -	cpumask_set_cpu(cpu, &cqm_cpumask);
> > > +	/* First online cpu in package becomes the reader */
> > > +	reader = cpumask_any_and(topology_core_cpumask(cpu), &cqm_cpumask);
> > > +	if (reader >= nr_cpu_ids)
> > > +		cpumask_set_cpu(cpu, &cqm_cpumask);
> > 
> > I was confused by the topology_core_cpumask naming as its really the mask of
> > all cpus in the same package. I sent a patch for cqm and rapl to fix this
> > looping when you had given the same feedback during CAt patches review , but
> > they have never made it so far due to CAT patch issues.
> 
> Duh, totally forgot about them.
>  
> > Would it be better to resend the rapl (looks like perf_uncore has same loop)
> > fixes separately ?
> 
> Yes, please resend the rapl one. perf_uncore is a different trainwreck which I
> fixed already:
> 
>       lkml.kernel.org/r/20160217132903.767990400@linutronix.de

And looking at rapl, it's the same trainwreck as uncore versus error
handling. Sigh....

Thanks,

	tglx

Thread

[PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 16:50 +0100
  Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 17:20 +0100
    Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-17 17:30 +0100
    Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-17 19:30 +0100
      Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 19:40 +0100
      Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 19:40 +0100
        Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-17 19:50 +0100
          Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 20:20 +0100
            Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Thomas Gleixner <tglx@linutronix.de> - 2016-02-18 21:20 +0100
              Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu  lookups Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-19 00:20 +0100

csiph-web