Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1336566
| From | Murali Karicheri <m-karicheri2@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality |
| Date | 2016-02-17 17:30 +0100 |
| Message-ID | <r3d9m-uB-129@gated-at.bofh.it> (permalink) |
| References | <r0gZK-4N6-41@gated-at.bofh.it> <r0jEd-6IG-3@gated-at.bofh.it> <r0jNU-6Mt-9@gated-at.bofh.it> <r0miJ-8tA-9@gated-at.bofh.it> |
| Organization | Texas Instruments |
On 02/09/2016 02:38 PM, Arnd Bergmann wrote: > On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote: >> The descriptors are usable by different drivers, one driver may use it as >> buf ptr/ len, other for something else. So they should remain as generic >> and it is up to individual drivers to use it in whatever way it requires. >> My suggestion is to rename pad field in struct knav_dma_desc to sw_data >> to avoid confusion. i.e >> >> + __le32 pad[4]; >> >> to >> >> + __le32 sw_data[4]; >> > If the hardware doesn't access them, they can probably just be u32 > and not do any byte swapping. Agree. > > Arnd > -- Murali Karicheri Linux Kernel, Keystone
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: ti: netcp: restore get/set_pad_info() functionality Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-09 15:00 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality David Laight <David.Laight@ACULAB.COM> - 2016-02-09 15:20 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality "Karicheri, Muralidharan" <m-karicheri2@ti.com> - 2016-02-09 17:20 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality "Karicheri, Muralidharan" <m-karicheri2@ti.com> - 2016-02-09 17:20 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality David Laight <David.Laight@ACULAB.COM> - 2016-02-09 17:50 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality "Karicheri, Muralidharan" <m-karicheri2@ti.com> - 2016-02-09 18:00 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Arnd Bergmann <arnd@arndb.de> - 2016-02-09 20:40 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-10 09:40 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Murali Karicheri <m-karicheri2@ti.com> - 2016-02-17 17:30 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Murali Karicheri <m-karicheri2@ti.com> - 2016-02-18 18:10 +0100
RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality David Laight <David.Laight@ACULAB.COM> - 2016-02-09 17:20 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality David Miller <davem@davemloft.net> - 2016-02-16 21:30 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Murali Karicheri <m-karicheri2@ti.com> - 2016-02-18 18:20 +0100
Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality David Miller <davem@davemloft.net> - 2016-02-18 21:10 +0100
csiph-web