Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning
Date	2016-02-18 20:20 +0100
Message-ID	<r3Chk-1Pm-5@gated-at.bofh.it> (permalink)
References	<r3xKG-6WT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Geliang Tang <geliangtang@163.com> writes:
> On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
>> kbuild test robot <lkp@intel.com> writes:
>> > All errors (new ones prefixed by >>):
>> >
>> >    drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue':
>> >>> drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function)
>> >      plist = phead->next;
>> >      ^
>> 
>> This doesn't work, you cannot break interim builds. Your patch 2 needs
>> to go before patch 1, and you must always check that they compile for
>> each patch you apply.
>> 
>> NACK
>
> Sorry for the trouble caused. I updated my patchs to fix this problem.
>
> - Geliang
>
> This patch set uses list_for_each_entry*() instead of
> list_for_each*(), removes useless codes, and cleans
> whitespaces and blank lines.

No worries, I much prefer taking a few rounds to get it right.

This set looks good to me.

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-02-17 18:30 +0100
  [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang <geliangtang@163.com> - 2016-02-18 15:30 +0100
    [PATCH v5 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang <geliangtang@163.com> - 2016-02-18 15:30 +0100
    Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-02-18 20:20 +0100

csiph-web