Re: [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*()

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*()
Date	2016-02-17 18:30 +0100
Message-ID	<r3e5m-19i-35@gated-at.bofh.it> (permalink)
References	<r3c3w-8ba-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

kbuild test robot <lkp@intel.com> writes:
> Hi Geliang,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.5-rc4 next-20160217]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Geliang-Tang/staging-rtl8723au-use-list_for_each_entry/20160217-220638
> config: i386-randconfig-s1-201607 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> Note: the linux-review/Geliang-Tang/staging-rtl8723au-use-list_for_each_entry/20160217-220638 HEAD 495811a52aba181af76c3baf57da3d81a79c2fe8 builds fine.
>       It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
>    drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue':
>>> drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function)
>      plist = phead->next;
>      ^

This doesn't work, you cannot break interim builds. Your patch 2 needs
to go before patch 1, and you must always check that they compile for
each patch you apply.

NACK

Jes

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-02-17 18:30 +0100
  [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang <geliangtang@163.com> - 2016-02-18 15:30 +0100
    [PATCH v5 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang <geliangtang@163.com> - 2016-02-18 15:30 +0100
    Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-02-18 20:20 +0100

csiph-web