Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337632

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Show all headers | View raw

Hi Peter,

On 18 February 2016 at 23:18, Peter Hurley <peter@hurleysoftware.com> wrote:
> Hi Anand,
>
> On 02/18/2016 09:40 AM, Anand Moon wrote:
>> From: Anand Moon <linux.amoon@gmail.com>
>>
>> changes fix the correct order of the spin_lock_irqrestore/save.
>>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  drivers/tty/serial/samsung.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>> index d72cd73..96fe14d 100644
>> --- a/drivers/tty/serial/samsung.c
>> +++ b/drivers/tty/serial/samsung.c
>> @@ -759,9 +759,9 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id)
>>       }
>>
>>       if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
>> -             spin_unlock(&port->lock);
>> +             spin_unlock_irqrestore(&port->lock, flags);
>>               uart_write_wakeup(port);
>> -             spin_lock(&port->lock);
>> +             spin_lock_irqsave(&port->lock, flags);
>
> This driver shouldn't be dropping the spin lock at for write wakeup.
> If this is causing lock-ups in a line discipline, the line discipline
> needs fixed.
>

Thanks for pointing out.
Their is no lock up, just the inconstancy of the spin_lock.
Then I will resend this patch dropping the spin_unlock/spin_lock
around uart_write_wakeup.
Is that ok with you.

> Regards,
> Peter Hurley
>
>
>>       }
>>
>>       if (uart_circ_empty(xmit))
>>
>

Best Regards
-Anand Moon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: samsung: fix the inconsistency in spinlock Anand Moon <linux.amoon@gmail.com> - 2016-02-18 18:50 +0100
  Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Peter Hurley <peter@hurleysoftware.com> - 2016-02-18 18:50 +0100
    Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Anand Moon <linux.amoon@gmail.com> - 2016-02-18 20:20 +0100
      Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Peter Hurley <peter@hurleysoftware.com> - 2016-02-18 21:10 +0100
      Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 07:20 +0100
        Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Anand Moon <linux.amoon@gmail.com> - 2016-02-19 08:00 +0100
          Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 08:50 +0100
            Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 09:30 +0100
              Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Anand Moon <linux.amoon@gmail.com> - 2016-02-19 09:40 +0100
                Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-21 02:40 +0100
            Re: [PATCH] serial: samsung: fix the inconsistency in spinlock Anand Moon <linux.amoon@gmail.com> - 2016-02-19 09:30 +0100

csiph-web