Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332829

Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()
Date 2016-02-12 17:00 +0100
Message-ID <r1oiu-ws-3@gated-at.bofh.it> (permalink)
References <r0Of0-1Jz-17@gated-at.bofh.it> <r1fyx-3eM-7@gated-at.bofh.it> <r1lND-7uT-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 12-02-16, 14:18, Rafael J. Wysocki wrote:
> Well, having a check that never fails is certainly unuseful.
> 
> > So, even we may want to add a WARN_ON() for that case instead.
> 
> I can add WARN_ON()s just fine.

What about dropping the check completely ?

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-11 02:30 +0100
  Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 07:40 +0100
    Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 14:20 +0100
      Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:00 +0100
        Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 17:10 +0100
          Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:30 +0100

csiph-web