Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332829

Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()
Date Fri, 12 Feb 2016 17:00:02 +0100
Message-ID <r1oiu-ws-3@gated-at.bofh.it> (permalink)
References <r0Of0-1Jz-17@gated-at.bofh.it> <r1fyx-3eM-7@gated-at.bofh.it> <r1lND-7uT-1@gated-at.bofh.it>
X-Original-To "Rafael J. Wysocki" <rjw@rjwysocki.net>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=mLa5USPMJ+ffMDtXewlpTGK5Tv7uczVCJ80NT6/N8G0=; b=QukVR8bGPKK3HliRwLZvS8wAxvHQF1Hf7lGbEy/8wOlWFLbG9/KblsL1YR5VUC/AVe UMaC3Ug7GEBSAd4+GLMIgdVmMTZdRMOIaTR+twHPJpen70u13Iwx312Noi0ATE7mQlC3 yqWSk+WlKwAOigSYQfh0HDYMbmu9w9ja2hgT4=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=mLa5USPMJ+ffMDtXewlpTGK5Tv7uczVCJ80NT6/N8G0=; b=iZSK29M3HkHjdyMAqUhpwsiuzYwtvFaP9VUWAaZl+5UeuyBORrJxWI75qenBkdbXKP TqqiE7D9PovOUX0Gy53X70+XXqbuBlR/OZcnou45DRS8C9Nsd+NCFiJTumzSYUaJvwQx SHpmzPXZOdkq4DrT88I+sNFuvd7eY1ssJ9qvshaaW5c95p2C1aPpjGJ2y7c3z9cWPSvf /IkLbFG+65IzgeNlYu9I3Z5TJHYkgGIYufDtKT/HTVtzVlxjYd8qyWDGP/KN+tgH++Jz /b6Mad9wlHFQMuTyvfobxWPX+vLHNQHXlVUEr5FcjNQBPJVrBKJ/KU/fSmSc7eBq95bz BeYA==
X-Gm-Message-State AG10YOTbHyinpwkLQ7rBqlzRFL+EPKrtm4aBqmP3FZ1KL1ZV0HocaoPQlN1yu4wNhhsAG6P9
X-Received by 10.67.7.42 with SMTP id cz10mr3178394pad.158.1455292713686; Fri, 12 Feb 2016 07:58:33 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 11
Organization linux.* mail to news gateway
X-Original-Cc Linux PM list <linux-pm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date Fri, 12 Feb 2016 21:28:29 +0530
X-Original-Message-ID <20160212155829.GA32705@vireshk-i7>
X-Original-References <2946666.LCVBdOefy1@vostro.rjw.lan> <20160212063115.GE16949@vireshk-i7> <16931364.qnKxgPucoY@vostro.rjw.lan>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1332829

Show key headers only | View raw


On 12-02-16, 14:18, Rafael J. Wysocki wrote:
> Well, having a check that never fails is certainly unuseful.
> 
> > So, even we may want to add a WARN_ON() for that case instead.
> 
> I can add WARN_ON()s just fine.

What about dropping the check completely ?

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-11 02:30 +0100
  Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 07:40 +0100
    Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 14:20 +0100
      Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:00 +0100
        Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 17:10 +0100
          Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:30 +0100

csiph-web