Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()
Date	2016-02-12 17:30 +0100
Message-ID	<r1oLv-Wf-1@gated-at.bofh.it> (permalink)
References	<r0Of0-1Jz-17@gated-at.bofh.it> <r1lND-7uT-1@gated-at.bofh.it> <r1oiu-ws-3@gated-at.bofh.it> <r1os9-Pl-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12-02-16, 17:10, Rafael J. Wysocki wrote:
> On Friday, February 12, 2016 09:28:29 PM Viresh Kumar wrote:
> > On 12-02-16, 14:18, Rafael J. Wysocki wrote:
> > > Well, having a check that never fails is certainly unuseful.
> > > 
> > > > So, even we may want to add a WARN_ON() for that case instead.
> > > 
> > > I can add WARN_ON()s just fine.
> > 
> > What about dropping the check completely ?
> 
> Fine by me.
> 
> ---
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Subject: [PATCH] cpufreq: Drop unnecessary checks from show() and store()
> 
> The show() and store() routines in the cpufreq core don't need to
> check if the struct freq_attr they want to use really provides the
> callbacks they need as expected (if that's not the case, it means
> a bug in the code anyway), so change them to avoid doing that.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq.c |   21 +++++----------------
>  1 file changed, 5 insertions(+), 16 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-11 02:30 +0100
  Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 07:40 +0100
    Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 14:20 +0100
      Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:00 +0100
        Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-12 17:10 +0100
          Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-12 17:30 +0100

csiph-web