Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275340

Re: dwarf unwinder question

Show all headers | View raw

>>> On 23.11.15 at 14:03, <Vineet.Gupta1@synopsys.com> wrote:
> I was wondering if u could answer a question in that respect: 
> arch/arc/kernel/unwind.c
> 
> If the binary search for a PC fails, it resorts to linear search, which for 
> our
> case was taking 3 million cycles (vs. normal ~2000).
> Do you remember why this linear search step was needed - after all the binary
> lookup table is created out of early parsing of the same data.
> 
> The fail scenario is for hand asm symbols lacking gcc generated dwarf info 
> and we
> don't have yet the CFI pseudo ops support in assembler.
> I can fix memset etc to have empty dwarf info, still unwinder needs this 
> fixing.
> 
> In case of perf, an overflow interrupt in hand optimized memset leads into 
> the
> unwinder slow path linear search which causes RCU stalls and such.
> I'm going to remove it but was wondering if u could provide some historic 
> background.

Iirc there was no binary lookup at all originally. When it got added,
it seemed odd to remove the linear lookup altogether (want to keep
it at least for the case where the binary lookup table couldn't be
built for whatever reason), and code structure seemed most
reasonable to simply do one after the other instead of just either.
I'm pretty sure the linear lookup could be skipped if you're sure the
binary lookup table is correct and complete.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

dwarf unwinder question Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-11-23 14:10 +0100
  Re: dwarf unwinder question "Jan Beulich" <JBeulich@suse.com> - 2015-11-23 14:20 +0100
    Re: dwarf unwinder question Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-11-23 14:30 +0100
      Re: dwarf unwinder question "Jan Beulich" <JBeulich@suse.com> - 2015-11-23 14:50 +0100

csiph-web