Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them
Date	2015-11-19 19:30 +0100
Message-ID	<qwC82-4vu-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qqQx4-7Ef-21@gated-at.bofh.it> <qvuPh-1bQ-35@gated-at.bofh.it> <qvvLj-1Mp-5@gated-at.bofh.it> <qwmwi-2GZ-3@gated-at.bofh.it> <qwApA-3ke-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Doug Anderson <dianders@chromium.org> writes:
>>>> isn't this a regression ? You're first clearing the interrupts and only
>>>> then reading to check what's pending, however, what's pending has just
>>>> been cleared. Seems like this should be:
>>>>
>>>> hprt0 = dwc2_readl(HPRT0);
>>>> dwc2_writeal(PRTINT, GINTSTS);
>>>
>>> Actually, we could probably remove the setting of GINTSTS_PRTINT
>>> completely.  The docs I have say that the GINTSTS_PRTINT is read only
>>> and that:
>>>
>>>> The core sets this bit to indicate a change in port status of one of the
>>>> DWC_otg core ports in Host mode. The application must read the
>>>> Host Port Control and Status (HPRT) register to determine the exact
>>>> event that caused this interrupt. The application must clear the
>>>> appropriate status bit in the Host Port Control and Status register to
>>>> clear this bit.
>>>
>>> ...so writing PRTINT is probably useless, but John can confirm.
>>>
>>
>> Yup, it seems it can be removed.
>
> How do you guys want this handled?  Should I send up a new version of
> this patch?  ...or should I send a followon patch that does this
> removal?

I'll leave the final decision to John, but my opinion is that a new
version of the patch would be preferrable.

-- 
balbi

Thread

Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Felipe Balbi <balbi@ti.com> - 2015-11-16 17:30 +0100
  Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Doug Anderson <dianders@chromium.org> - 2015-11-16 18:30 +0100
    Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before  handling them John Youn <John.Youn@synopsys.com> - 2015-11-19 02:50 +0100
      Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Doug Anderson <dianders@chromium.org> - 2015-11-19 17:40 +0100
        Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Felipe Balbi <balbi@ti.com> - 2015-11-19 19:30 +0100
          Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before  handling them John Youn <John.Youn@synopsys.com> - 2015-11-19 20:20 +0100

csiph-web