Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them
Date	Thu, 19 Nov 2015 19:30:02 +0100
Message-ID	<qwC82-4vu-7@gated-at.bofh.it> (permalink)
References	<qqQx4-7Ef-7@gated-at.bofh.it> <qqQx4-7Ef-21@gated-at.bofh.it> <qvuPh-1bQ-35@gated-at.bofh.it> <qvvLj-1Mp-5@gated-at.bofh.it> <qwmwi-2GZ-3@gated-at.bofh.it> <qwApA-3ke-17@gated-at.bofh.it>
X-Original-To	Doug Anderson <dianders@chromium.org>, John Youn <John.Youn@synopsys.com>
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	68
Organization	linux.* mail to news gateway
X-Original-Cc	Yunzhi Li <lyz@rock-chips.com>, Heiko Stübner <heiko@sntech.de>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Julius Werner <jwerner@chromium.org>, "Herrero, Gregory" <gregory.herrero@intel.com>, "Kaukab, Yousaf" <yousaf.kaukab@intel.com>, Dinh Nguyen <dinguyen@opensource.altera.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 19 Nov 2015 12:19:14 -0600
X-Original-Message-ID	<877fldg8d9.fsf@saruman.tx.rr.com>
X-Original-References	<1446582629-30091-1-git-send-email-dianders@chromium.org> <1446582629-30091-2-git-send-email-dianders@chromium.org> <87wpthnc2e.fsf@saruman.tx.rr.com> <CAD=FV=W-UWJnHZioChnVmPmJQXxMGGOUQiF81h0ZTA4invivVA@mail.gmail.com> <2B3535C5ECE8B5419E3ECBE30077290901DC3D696B@US01WEMBX2.internal.synopsys.com> <CAD=FV=WSypaenJcRjhneAkcW=K5J-q-+c7L2=vJj5YAoGaFncw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1273353

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Doug Anderson <dianders@chromium.org> writes:
>>>> isn't this a regression ? You're first clearing the interrupts and only
>>>> then reading to check what's pending, however, what's pending has just
>>>> been cleared. Seems like this should be:
>>>>
>>>> hprt0 = dwc2_readl(HPRT0);
>>>> dwc2_writeal(PRTINT, GINTSTS);
>>>
>>> Actually, we could probably remove the setting of GINTSTS_PRTINT
>>> completely.  The docs I have say that the GINTSTS_PRTINT is read only
>>> and that:
>>>
>>>> The core sets this bit to indicate a change in port status of one of the
>>>> DWC_otg core ports in Host mode. The application must read the
>>>> Host Port Control and Status (HPRT) register to determine the exact
>>>> event that caused this interrupt. The application must clear the
>>>> appropriate status bit in the Host Port Control and Status register to
>>>> clear this bit.
>>>
>>> ...so writing PRTINT is probably useless, but John can confirm.
>>>
>>
>> Yup, it seems it can be removed.
>
> How do you guys want this handled?  Should I send up a new version of
> this patch?  ...or should I send a followon patch that does this
> removal?

I'll leave the final decision to John, but my opinion is that a new
version of the patch would be preferrable.

-- 
balbi

Thread

Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Felipe Balbi <balbi@ti.com> - 2015-11-16 17:30 +0100
  Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Doug Anderson <dianders@chromium.org> - 2015-11-16 18:30 +0100
    Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before  handling them John Youn <John.Youn@synopsys.com> - 2015-11-19 02:50 +0100
      Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Doug Anderson <dianders@chromium.org> - 2015-11-19 17:40 +0100
        Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Felipe Balbi <balbi@ti.com> - 2015-11-19 19:30 +0100
          Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before  handling them John Youn <John.Youn@synopsys.com> - 2015-11-19 20:20 +0100

csiph-web