Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1271654

[PATCH] USB: USB_OTG does not depend on PM

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH] USB: USB_OTG does not depend on PM
Date 2015-11-17 22:10 +0100
Message-ID <qvVFM-1Tz-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


USB_OTG initially depended on USB_SUSPEND, which was later turned into
PM_RUNTIME and finally into PM. I don't know at what point the dependency
became unnecessary but it appears to work fine without CONFIG_PM now.

However, we get lots of warnings in randconfig kernels like:

warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)

whenever CONFIG_PM is disabled and something else selects USB_OTG.
Let's just drop the dependency to avoid the warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I keep seeing this one in my ARM randconfig test

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index a99c89e78126..9c5cdf30ca74 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
 	default n
 	help
 	  The most notable feature of USB OTG is support for a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 22:10 +0100
  Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 22:40 +0100
    Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 23:10 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 23:30 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-18 10:40 +0100

csiph-web