Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271654 > unrolled thread

[PATCH] USB: USB_OTG does not depend on PM

Back to article view | Back to linux.kernel

Contents

  [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 22:10 +0100
    Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 22:40 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 23:10 +0100
        Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 23:30 +0100
        Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-18 10:40 +0100

#1271654 — [PATCH] USB: USB_OTG does not depend on PM

USB_OTG initially depended on USB_SUSPEND, which was later turned into
PM_RUNTIME and finally into PM. I don't know at what point the dependency
became unnecessary but it appears to work fine without CONFIG_PM now.

However, we get lots of warnings in randconfig kernels like:

warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)

whenever CONFIG_PM is disabled and something else selects USB_OTG.
Let's just drop the dependency to avoid the warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I keep seeing this one in my ARM randconfig test

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index a99c89e78126..9c5cdf30ca74 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
 	default n
 	help
 	  The most notable feature of USB OTG is support for a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1271682

[Multipart message — attachments visible in raw view] — view raw

Hi,

Arnd Bergmann <arnd@arndb.de> writes:
> USB_OTG initially depended on USB_SUSPEND, which was later turned into
> PM_RUNTIME and finally into PM. I don't know at what point the dependency
> became unnecessary but it appears to work fine without CONFIG_PM now.
>
> However, we get lots of warnings in randconfig kernels like:
>
> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>
> whenever CONFIG_PM is disabled and something else selects USB_OTG.
> Let's just drop the dependency to avoid the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I keep seeing this one in my ARM randconfig test

and how did you test this ? Did you make sure you're not breaking HNP ?
For HNP to happen we depend on a bus_suspend and bus_suspend is only
available on CONFIG_PM, unless that has changed.

Seems like you've only compile tested this patch, is that correct ?

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1271694

On Tuesday 17 November 2015 15:38:33 Felipe Balbi wrote:
> 
> Arnd Bergmann <arnd@arndb.de> writes:
> > USB_OTG initially depended on USB_SUSPEND, which was later turned into
> > PM_RUNTIME and finally into PM. I don't know at what point the dependency
> > became unnecessary but it appears to work fine without CONFIG_PM now.
> >
> > However, we get lots of warnings in randconfig kernels like:
> >
> > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
> >
> > whenever CONFIG_PM is disabled and something else selects USB_OTG.
> > Let's just drop the dependency to avoid the warnings.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > I keep seeing this one in my ARM randconfig test
> 
> and how did you test this ? Did you make sure you're not breaking HNP ?
> For HNP to happen we depend on a bus_suspend and bus_suspend is only
> available on CONFIG_PM, unless that has changed.
> 
> Seems like you've only compile tested this patch, is that correct ?

Yes, I compile-tested only and inspected the code briefly without finding
anything that contradicted this. It seems I missed the important part
as you say, so we should instead add 'depends on PM' for the other
symbols.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1271704

[Multipart message — attachments visible in raw view] — view raw

Hi,

Arnd Bergmann <arnd@arndb.de> writes:
> On Tuesday 17 November 2015 15:38:33 Felipe Balbi wrote:
>> 
>> Arnd Bergmann <arnd@arndb.de> writes:
>> > USB_OTG initially depended on USB_SUSPEND, which was later turned into
>> > PM_RUNTIME and finally into PM. I don't know at what point the dependency
>> > became unnecessary but it appears to work fine without CONFIG_PM now.
>> >
>> > However, we get lots of warnings in randconfig kernels like:
>> >
>> > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>> >
>> > whenever CONFIG_PM is disabled and something else selects USB_OTG.
>> > Let's just drop the dependency to avoid the warnings.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > ---
>> > I keep seeing this one in my ARM randconfig test
>> 
>> and how did you test this ? Did you make sure you're not breaking HNP ?
>> For HNP to happen we depend on a bus_suspend and bus_suspend is only
>> available on CONFIG_PM, unless that has changed.
>> 
>> Seems like you've only compile tested this patch, is that correct ?
>
> Yes, I compile-tested only and inspected the code briefly without finding
> anything that contradicted this. It seems I missed the important part
> as you say, so we should instead add 'depends on PM' for the other
> symbols.

right, that might be better. I'll still read that code again, it has
been a few years since I looked at hnp at all.

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1272046

On Wednesday 18 November 2015 11:17:50 Peter Chen wrote:
> From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001
> From: Peter Chen <peter.chen@freescale.com>
> Date: Wed, 18 Nov 2015 11:06:34 +0800
> Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG
> 
> When choose randconfig for kernel build, it reports below warning:
> "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
> which has unmet direct dependencies (USB_SUPPORT && USB && PM)"
> 
> In fact, USB_OTG is visual symbol and depends on PM, so the driver

                      visible ?

> needs to depend on it to reduce dependency problem.
> 
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Felipe Balbi <balbi@ti.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I was a bit worried that this might break defconfig files that now
no longer automatically get OSB_OTG enabled, but I have checked all
defconfig files we have in the kernel and none of them uses
USB_OTG_FSM, FSL_USB2_OTG or USB_MV_OTG, so we are fine.

Thanks!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web