Groups > linux.kernel > #1272046

Re: [PATCH] USB: USB_OTG does not depend on PM

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] USB: USB_OTG does not depend on PM
Date	2015-11-18 10:40 +0100
Message-ID	<qw7nC-13M-37@gated-at.bofh.it> (permalink)
References	<qvVFM-1Tz-7@gated-at.bofh.it> <qvWBR-2uT-15@gated-at.bofh.it> <qw7nC-13M-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 18 November 2015 11:17:50 Peter Chen wrote:
> From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001
> From: Peter Chen <peter.chen@freescale.com>
> Date: Wed, 18 Nov 2015 11:06:34 +0800
> Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG
> 
> When choose randconfig for kernel build, it reports below warning:
> "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
> which has unmet direct dependencies (USB_SUPPORT && USB && PM)"
> 
> In fact, USB_OTG is visual symbol and depends on PM, so the driver

                      visible ?

> needs to depend on it to reduce dependency problem.
> 
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Felipe Balbi <balbi@ti.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I was a bit worried that this might break defconfig files that now
no longer automatically get OSB_OTG enabled, but I have checked all
defconfig files we have in the kernel and none of them uses
USB_OTG_FSM, FSL_USB2_OTG or USB_MV_OTG, so we are fine.

Thanks!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 22:10 +0100
  Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 22:40 +0100
    Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 23:10 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 23:30 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-18 10:40 +0100

csiph-web