Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266388

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

Show all headers | View raw

On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote:
> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
> is never used.

That's not true since the arm64 definition seems to take precedence.

> This adds a dependency on DEBUG_KERNEL for building with frame pointers.

It doesn't because arm64 selects ARCH_WANT_FRAME_POINTERS.

> ARM64 depends on frame pointer to get correct stack backtrace and need
> FRAME_POINTER kconfig option enabled all the time.
> However, currect implementation makes it could be disabled, so force it
> to be selected by ARM64.
> 
> Signed-off-by: Yang Shi <yang.shi@linaro.org>

Patch applied but I changed the commit log slightly. Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Yang Shi <yang.shi@linaro.org> - 2015-11-09 19:30 +0100
  Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 11:40 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:10 +0100
      Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 12:40 +0100
        Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:50 +0100
          Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Will Deacon <will.deacon@arm.com> - 2015-11-10 13:00 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it "Shi, Yang" <yang.shi@linaro.org> - 2015-11-10 18:00 +0100

csiph-web