Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265932

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

From Yang Shi <yang.shi@linaro.org>
Newsgroups linux.kernel
Subject [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it
Date 2015-11-09 19:30 +0100
Message-ID <qsZmz-1yW-41@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
is never used.
This adds a dependency on DEBUG_KERNEL for building with frame pointers.

ARM64 depends on frame pointer to get correct stack backtrace and need
FRAME_POINTER kconfig option enabled all the time.
However, currect implementation makes it could be disabled, so force it
to be selected by ARM64.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
change v3 --> v2:
squash two patches into one.

 arch/arm64/Kconfig       | 1 +
 arch/arm64/Kconfig.debug | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 440d906..b554da2 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -27,6 +27,7 @@ config ARM64
 	select CPU_PM if (SUSPEND || CPU_IDLE)
 	select DCACHE_WORD_ACCESS
 	select EDAC_SUPPORT
+	select FRAME_POINTER
 	select GENERIC_ALLOCATOR
 	select GENERIC_CLOCKEVENTS
 	select GENERIC_CLOCKEVENTS_BROADCAST
diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug
index d6285ef..915dea7 100644
--- a/arch/arm64/Kconfig.debug
+++ b/arch/arm64/Kconfig.debug
@@ -2,10 +2,6 @@ menu "Kernel hacking"
 
 source "lib/Kconfig.debug"
 
-config FRAME_POINTER
-	bool
-	default y
-
 config ARM64_PTDUMP
 	bool "Export kernel pagetable layout to userspace via debugfs"
 	depends on DEBUG_KERNEL
-- 
2.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Yang Shi <yang.shi@linaro.org> - 2015-11-09 19:30 +0100
  Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 11:40 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:10 +0100
      Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 12:40 +0100
        Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:50 +0100
          Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Will Deacon <will.deacon@arm.com> - 2015-11-10 13:00 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it "Shi, Yang" <yang.shi@linaro.org> - 2015-11-10 18:00 +0100

csiph-web