Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it
Date	2015-11-10 13:00 +0100
Message-ID	<qtfKG-4Aq-19@gated-at.bofh.it> (permalink)
References	<qsZmz-1yW-41@gated-at.bofh.it> <qtevf-3RD-5@gated-at.bofh.it> <qteYi-4iG-35@gated-at.bofh.it> <qtfrk-4tg-17@gated-at.bofh.it> <qtfB0-4wQ-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote:
> > On Nov 10, 2015, at 19:35, Catalin Marinas <catalin.marinas@arm.com> wrote:
> > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote:
> >> i have a question,
> >> why FRAME_POINTER  config must be enabled ?
> >> and i see ARM arch can  disable this config .
> >> if i don’t need stack trace dump and the software release is for 
> >> final product , don’t need debug stack trace log .
> >> is it possible to disable it for performance reason ?
> > 
> > If you don't need any stack trace, perf etc., in theory you can disable
> > the option. However, the aarch64 gcc compiler always generates it (I'm
> > not sure whether the AAPCS mandates it). Anyway, the performance impact
> > is very small since there are more general purpose registers available
> > in AArch64 already.
> > 
> i just make a test with -fomit-frame-pointer,  seems gcc can generate code
> without frame pointer,

Building without frame-pointers *severely* limits our ability (as
open-source developers) to debug problems that we are unable to reproduce
locally. Given the lack of widely available hardware compared to the
number of platforms in development, I'm strongly opposed to offering this
as a supported option for mainline kernels without a compelling performance
argument.

We have a significant number of general-purpose registers available on
arm64, so I would expect the omission of a framepointer to have a
somewhat limited impact on performance.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Yang Shi <yang.shi@linaro.org> - 2015-11-09 19:30 +0100
  Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 11:40 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:10 +0100
      Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Catalin Marinas <catalin.marinas@arm.com> - 2015-11-10 12:40 +0100
        Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:50 +0100
          Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it Will Deacon <will.deacon@arm.com> - 2015-11-10 13:00 +0100
    Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option  and force to select it "Shi, Yang" <yang.shi@linaro.org> - 2015-11-10 18:00 +0100

csiph-web