Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()
Date	2015-11-12 11:50 +0100
Message-ID	<qtXC2-7M0-17@gated-at.bofh.it> (permalink)
References	<qtXiG-7Fc-15@gated-at.bofh.it> <qtMGB-Q4-11@gated-at.bofh.it> <qtX91-7C4-19@gated-at.bofh.it> <qtXiG-7Fc-15@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> > This isn't quite the right solution.  The uninitialised error path needs to
> > set -ENOBUFS.
> 
> That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the
> page immediately beyond the EOF marker") does, and is also in its commit
> description:
> 
>     Whilst we're at it, change the triggered assertion in CacheFiles to just
>     return -ENOBUFS instead.
> 
> "ret" is used only to print the original error in a debug message.

I'll adjust your patch to set the default value in ret to be -ENOBUFS instead
of 0.

> > Unfortunately, my compiler doesn't show a warning:-/
> 
> Need old gcc (4.1.2 ;-)

Quite possibly - gcc-5.1 does seem to be a bit lacking in detection of such
things.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 00:10 +0100
  Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:20 +0100
    Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:30 +0100
      Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:50 +0100
        Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:50 +0100

csiph-web